Re: Test to dump and restore objects left behind by regression - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Test to dump and restore objects left behind by regression
Date
Msg-id x7yvss2kwwhbg6griakxfmddpsf5lqsqvqggo5hl4ttphy6dlv@o7dmoocl2yfe
Whole thread Raw
In response to Re: Test to dump and restore objects left behind by regression  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2025-04-04 12:01:16 -0400, Andres Freund wrote:
> FWIW, for me 027 is actually considerably faster. In an cassert -O0 build (my
> normal development env, I find even -Og too problematic for debugging):
> 
> pg_upgrade/002_pg_upgrade    96.61s
> recovery/027_stream_regress  66.04s
> 
> After
>   git revert 8806e4e8deb1e21715e031e17181d904825a410e abe56227b2e213755dd3e194c530f5f06467bd7c
172259afb563d35001410dc6daad78b250924038
> 
> pg_upgrade/002_pg_upgrade    75.09s
> 
> Slower by 29%, far from the 3s increased time I saw mentioned somewhere.
> 
> 
> And this really affects the overall test time:
> 
> All tests before:
>     real    1m38.173s
>     user    5m52.500s
>     sys    4m23.574s
> 
> All tests after:
>     real    2m0.397s
>     user    5m53.625s
>     sys    4m30.518s
> 
> The CPU time increase is rather minimal, but the wall clock time increase is
> 22%.
> 
> 17:
>     real    1m14.822s
>     user    4m2.630s
>     sys    3m22.384s
> 
> We regressed wall clock time *60%* from 17->18. Some test cycle increase is
> reasonable and can largely be compensated with hardware, but this cycle we're
> growing way faster than hardware gets faster.  I don't think that's
> sustainable.

FWIW, with cassert and -O2, it's:

17:
    real    0m53.981s
    user    3m22.837s
    sys    3m24.237s

HEAD:
    real    1m19.749s
    user    4m54.526s
    sys    4m15.657s

so this isn't just due to me using -O0. A 48% increase is better than a 60%
increase, but it's still not sustainable.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Replace IN VALUES with ANY in WHERE clauses during optimization
Next
From: Melanie Plageman
Date:
Subject: Re: New criteria for autovacuum