Re: C11 / VS 2019 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: C11 / VS 2019
Date
Msg-id vm3bg6brdnr55acely45hchvpgpbxad3755tsyfcuaud4lhfrd@x7toglsdghfx
Whole thread Raw
In response to Re: C11 / VS 2019  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: C11 / VS 2019
List pgsql-hackers
Hi,

On 2025-07-18 14:12:34 +0300, Peter Eisentraut wrote:
> I also moved the test a bit earlier in meson.build, as a separate patch,
> because between the place where the compiler is first set up and the place
> where we detected the C99 options, if any, there were already some tests run
> that use the compiler.  I don't think this was a big problem in practice,
> but it seems a bit incorrect, so it makes sense to correct it.

I distinctly dislike this. You mashed a compiler test in the middle of
something else, without updating any comments. We now do one compiler test
earlier, then dependency tests, and then other compiler tests.  Doing anything
the order we do it in autoconf is an anti-argument, because the ordering we
use in autoconf is completely unintelligible.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: Sequence Access Methods, round two
Next
From: torikoshia
Date:
Subject: Re: Enhancing Memory Context Statistics Reporting