Re: Sequence Access Methods, round two - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: Sequence Access Methods, round two
Date
Msg-id CALdSSPh4eEcR3xmMNdPRtaYYdVx+8UDo8uaub19PVZM4+vEvog@mail.gmail.com
Whole thread Raw
In response to Re: Sequence Access Methods, round two  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Sequence Access Methods, round two
Re: Sequence Access Methods, round two
List pgsql-hackers
On Mon, 18 Aug 2025 at 09:49, Michael Paquier <michael@paquier.xyz> wrote:
>

> We could just
> reuse AlterColumn, saving from the extra sub-command.  What do you
> think?

Yes, this resonates with me better.

> Rebased the rest as attached, for now.

I have a small enhancement to the patch set.
In v17-0003:
```
reshke@yezzey-cbdb-bench:~/cpg$ git diff
diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 8ac13b26fe6..84b7f55fd73 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -3365,7 +3365,7 @@ match_previous_words(int pattern_id,
                COMPLETE_WITH("TYPE");
        /* Complete "CREATE ACCESS METHOD <name> TYPE" */
        else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny, "TYPE"))
-               COMPLETE_WITH("INDEX", "TABLE");
+               COMPLETE_WITH("INDEX", "TABLE", "SEQUENCE");
        /* Complete "CREATE ACCESS METHOD <name> TYPE <type>" */
        else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny,
"TYPE", MatchAny))
                COMPLETE_WITH("HANDLER");
```


-- 
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: Andres Freund
Date:
Subject: Re: C11 / VS 2019