Re: Speed up ICU case conversion by using ucasemap_utf8To*() - Mailing list pgsql-hackers

From zengman
Subject Re: Speed up ICU case conversion by using ucasemap_utf8To*()
Date
Msg-id tencent_32015AAF279D4D696813121C@qq.com
Whole thread Raw
In response to Re: Speed up ICU case conversion by using ucasemap_utf8To*()  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Speed up ICU case conversion by using ucasemap_utf8To*()
List pgsql-hackers
Hi Andreas,

On the mailing list, I've noticed this patch. I tested its functionality and it works really well. I have a few minor,
non-criticalcomments to share.
 
In the `pg_ucasemap_open` function, the error message `casemap lookup failed:` doesn't seem ideal. This is because
we'reopening the `UCaseMap` here, rather than performing a "lookup" operation.
 
In the comment `Additional makes sure we get the right options for case folding.`, the word Additional seems
inappropriate— `Additionally` would be a better replacement.
 


--
Regards,
Man Zeng
www.openhalo.org

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Wrong comment for ReplicationSlotCreate
Next
From: jian he
Date:
Subject: Re: disallow alter individual column if partition key contains wholerow reference