Re: Speed up ICU case conversion by using ucasemap_utf8To*() - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: Speed up ICU case conversion by using ucasemap_utf8To*()
Date
Msg-id 4cfde442-25dd-495f-8d76-a23502ce17b8@proxel.se
Whole thread Raw
In response to Re: Speed up ICU case conversion by using ucasemap_utf8To*()  ("zengman" <zengman@halodbtech.com>)
List pgsql-hackers
On 12/31/25 3:36 AM, zengman wrote:
> On the mailing list, I've noticed this patch. I tested its functionality and it works really well. I have a few
minor,non-critical comments to share.
 

Thanks for trying it out!

> In the `pg_ucasemap_open` function, the error message `casemap lookup failed:` doesn't seem ideal. This is because
we'reopening the `UCaseMap` here, rather than performing a "lookup" operation.
 

Fixed.

> In the comment `Additional makes sure we get the right options for case folding.`, the word Additional seems
inappropriate— `Additionally` would be a better replacement.
 
Fixed.

Andreas

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Next
From: Andrew Dunstan
Date:
Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy