Re: Do not lock tables in get_tables_to_repack - Mailing list pgsql-hackers

From cca5507
Subject Re: Do not lock tables in get_tables_to_repack
Date
Msg-id tencent_3188B53829333244786E072B7611A1F48508@qq.com
Whole thread
In response to Re: Do not lock tables in get_tables_to_repack  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Do not lock tables in get_tables_to_repack
List pgsql-hackers
> > > Any opinions on this?
> >
> > I will take a closer look at this in a bit.
>
> Patch looks good to me. One nit:
>
> + table_oid = IndexGetRelation(child_oid, true);
> + if (!OidIsValid(table_oid))
> + continue;
>
> How about a short comment on why this is needed even with a lock on
> the parent, since that lock doesn't cover lower-level leaves in a
> multi-level partition tree?

I think it's worth a comment, too. Patch LGTM.

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: for loop variable fixes
Next
From: Peter Eisentraut
Date:
Subject: Re: Update our timezone code to IANA tzcode2026b