Re: Update our timezone code to IANA tzcode2026b - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Update our timezone code to IANA tzcode2026b
Date
Msg-id 79c6cf48-2154-44d7-aed6-799c518a5c94@eisentraut.org
Whole thread
In response to Re: Update our timezone code to IANA tzcode2026b  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 01.06.26 02:55, Tom Lane wrote:
> I wrote:
>> Here's a patch to do $SUBJECT.
> 
> cfbot didn't like v1 too much, here's a v2.

I know you have already reported this upstream, but here are some 
patches to silence the resulting warnings on MSVC.

Patch 0001 just silences the warnings using pragmas.

Patch 0002 is to silence the "unary minus operator applied to unsigned 
type" warning globally for PostgreSQL.  AFAICT, there is no equivalent 
warning available on gcc or clang, so this would remain a trap on MSVC.

Patch 0003 is to silence the cross-enum comparison warnings using casts 
(as you had suggested to upstream).  I confirmed that this works in a 
small test case on Compiler Explorer (godbolt.org), but if I push this 
branch to GitHub Actions CI, the warning remains, so I don't know about 
this one.

Attachment

pgsql-hackers by date:

Previous
From: "cca5507"
Date:
Subject: Re: Do not lock tables in get_tables_to_repack
Next
From: Tomas Vondra
Date:
Subject: Re: allow spread checkpoints when changing checksums online