Re: Inline non-SQL SRFs using SupportRequestSimplify - Mailing list pgsql-hackers

From zengman
Subject Re: Inline non-SQL SRFs using SupportRequestSimplify
Date
Msg-id tencent_2DD7C01758D855FF70B3E6DD@qq.com
Whole thread Raw
In response to Re: Inline non-SQL SRFs using SupportRequestSimplify  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Well, from my perspective, the test logic for this feature seems a bit odd: 
even if you directly modify the function body to return NULL; or return 1/0;, 
none of this execution logic takes effect at all—it serves no purpose whatsoever as long as inlining succeeds.
This could be unfriendly to developers who are new to this feature, 
so I added a test for this scenario to verify that our logic falls back to the function body when inlining fails. 
This may just be my personal opinion, though; if you think everything is fine, we can leave it as it is.

--
Regards,
Man Zeng
www.openhalo.org

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: should we have a fast-path planning for OLTP starjoins?
Next
From: Xuneng Zhou
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded