Re: GetRelationPath() vs critical sections - Mailing list pgsql-hackers

From Andres Freund
Subject Re: GetRelationPath() vs critical sections
Date
Msg-id qhptvplcvag5kohfvkcclxgz7lllplrfnvsw4glzmvqxsfos5b@j2etjzjaroyw
Whole thread Raw
In response to Re: GetRelationPath() vs critical sections  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2025-02-20 15:28:39 -0500, Andres Freund wrote:
> On 2025-02-20 14:11:16 -0500, Tom Lane wrote:
> > As a matter of style, I wonder if it'd be better to have these
> > functions write into a caller-supplied variable.
> 
> I wondered about that too, it does however make some code more awkward,
> e.g. because there's not a good surrounding block to put the variable in.
> 
> I mildly prefer the return-by-value approach, but not more.

Since I've not heard anything on that point, I'm currently thinking with going
with return-by-value. Attached are two very mildly updated patches. Most of
the changes is added commit messages.

Greetings,

Andres Freund

Attachment

pgsql-hackers by date:

Previous
From: Andrew Jackson
Date:
Subject: Re: Add Option To Check All Addresses For Matching target_session_attr
Next
From: Peter Eisentraut
Date:
Subject: Re: Redact user password on pg_stat_statements