Re: Bug in pg_stat_statements - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: Bug in pg_stat_statements
Date
Msg-id ny3mdn3lmq47osrwqeadkeuncuotyvszizt2mmv63iagypp7xd@3jjjxkt4vwrr
Whole thread Raw
In response to Re: Bug in pg_stat_statements  (Sami Imseih <samimseih@gmail.com>)
List pgsql-hackers
> On Fri, Oct 24, 2025 at 07:04:59PM -0500, Sami Imseih wrote:
> v4 corrects some code comments.

The fix in the first patch looks good, thanks. Not so sure about the
refactoring in the second patch -- generate_normalized_query is being
used only in one place, in pg_stat_statements, moving it out somewhere
else without having other clients seems to be questionable to me.

P.S. Adding Álvaro as a commiter of the affected feature, maybe he will
help us to apply the fix.



pgsql-hackers by date:

Previous
From: Filip Janus
Date:
Subject: Re: Channel binding for post-quantum cryptography
Next
From: Tomas Vondra
Date:
Subject: Re: PG18 GIN parallel index build crash - invalid memory alloc request size