Thanks for reviewing!
>Not so sure about the
> refactoring in the second patch -- generate_normalized_query is being
> used only in one place, in pg_stat_statements, moving it out somewhere
> else without having other clients seems to be questionable to me.
The excellent question raised earlier is whether the fix should be
applied in pg_stat_statements.c or queryjumblefuncs.c. To me, this
suggests that pg_stat_statements, as an extension, is dealing with code
it should not be responsible for.
generate_normalized_query could be used by other extensions that have
normalization needs; it’s generic and needs to handle squashing, which
is a jumble specific detail.
Therefore, I think both fill_in_constant_lengths and
generate_normalized_query should be moved. We can certainly start a new
thread (0002) if more discussion is needed.
--
Sami Imseih
Amazon Web Services (AWS)
