Magnus Hagander <magnus@hagander.net> writes:
>> Why we can do it this way is because we're not starving on
>> reviewers. We're starving on commiters time. And seeing this:
>
> Well, we're actually somewhat starving on senior reviewers as well.
> That can take on things like the index patches, Writable CTE or SR.
> We're not starving on reviewers for small-to-medium patches.
We've been talking about having "specialized" reviewers, or multi
layered reviewing. There are several things we do in reviewing, and for
big enough patches there's no need to have the same reviewer do all of
them.
[...searching the archives for a proposal I did already send...]
http://archives.postgresql.org/pgsql-hackers/2009-08/msg00764.php
So this mail proposes we see those separate items to be handled in
review:
- patch (applies, merge, compiles, pass regression)- code reading (looks like it was already there, no WTF?) [1]-
documentation(covers code, targets users, is sufficient)- testing (code behavior is what is documented, works well)-
creativetesting (tried hard to crash it)- perf testing (profiling, no regression in non optimized cases...)- you name
it
Now the senior reviewers you're talking about are required the most for
code reading. We certainly still can have an army of junior reviewers,
or not-wannabe-hackers reviewers checking the other points. That'd push
the bottleneck some.
Regards,
--
dim
[1] http://www.osnews.com/images/comics/wtfm.jpg
