Hi,
On 2025-03-12 11:49:29 -0400, Tom Lane wrote:
> Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> > LGTM. I did some more testing and thought about it a little more, and
> > I can't see any other ways to break it.
>
> Thanks for the careful review and testing! Pushed after fooling
> with the comments a tiny bit more.
This seems to have introduce some breakage for 13-15. E.g. on
sifaka:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sifaka&dt=2025-03-12%2016%3A58%3A51
which has
'CPPFLAGS' => '-DWRITE_READ_PARSE_PLAN_TREES -DSTRESS_SORT_INT_MIN -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS'
diff -U3 /Users/buildfarm/bf-data/REL_14_STABLE/pgsql.build/src/test/regress/expected/tablespace.out
/Users/buildfarm/bf-data/REL_14_STABLE/pgsql.build/src/test/regress/results/tablespace.out
--- /Users/buildfarm/bf-data/REL_14_STABLE/pgsql.build/src/test/regress/expected/tablespace.out 2025-03-12 12:59:22
+++ /Users/buildfarm/bf-data/REL_14_STABLE/pgsql.build/src/test/regress/results/tablespace.out 2025-03-12 12:59:23
@@ -242,6 +242,7 @@
-- check \\d output
\\d testschema.foo
+WARNING: outfuncs/readfuncs failed to produce equal parse tree
Table "testschema.foo"
Column | Type | Collation | Nullable | Default
--------+---------+-----------+----------+---------
@@ -320,6 +321,7 @@
(3 rows)
...
Greetings,
Andres