Re: [HACKERS] Did the inet type get backed out? - Mailing list pgsql-hackers

From darcy@druid.net (D'Arcy J.M. Cain)
Subject Re: [HACKERS] Did the inet type get backed out?
Date
Msg-id m0zU8jZ-0000emC@druid.net
Whole thread Raw
In response to Re: [HACKERS] Did the inet type get backed out?  (Tom Ivar Helbekkmo <tih@nhh.no>)
Responses Re: [HACKERS] Did the inet type get backed out?  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
Thus spake Tom Ivar Helbekkmo
> darcy@druid.net (D'Arcy J.M. Cain) writes:
> > But it worked before.  In fact it still works on another system with
> > an earlier compile.
>
> "Works" for me, using a cvs update from yesterday morning (the morning
> after the BETA 2 freeze), modulo the fact that someone committed
> changes to #ifdef out ("#ifdef BAD") all the calls to the actual inet
> parser routines, effectively causing all data to be rejected.  Since

That's odd.  I know that Bruce #ifdef'd out the core of the _new_
functions I sent in but I didn't realize that he took the existing
ones out too.

> we had an implementation that actually worked, and the changes that we
> wanted to make were compatible with currently stored data, it would
> have been smarter to leave it working until the changes were ready to
> be committed.  It's better to be able to keep testing something that
> doesn't have all the wanted functionality than to disable it until an
> unknown time in the future!  :-)

Yes, I agree.  Bruce, can we put the inet_in and inet_out functions
back the way they were?

However, I have put all the code back in locally for testing so that
isn't why mine isn't working.  I'll try with today's sup.

--
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.

pgsql-hackers by date:

Previous
From: Edmund Mergl
Date:
Subject: Re: [HACKERS] perl interface bug?
Next
From: Sferacarta Software
Date:
Subject: bug on BETA2