Re: Patch for PKST timezone - Mailing list pgsql-hackers

From Joachim Wieland
Subject Re: Patch for PKST timezone
Date
Msg-id j2zdc7b844e1005111438g8da08eddu1e4fc070d8886104@mail.gmail.com
Whole thread Raw
In response to Re: Patch for PKST timezone  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Patch for PKST timezone
List pgsql-hackers
On Tue, May 11, 2010 at 10:45 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> I don't think we want to include all timezone names in the default
> config, timezone abbreviations aren't always unique for example. But we
> should include PKST because we already include PKT; it would be nasty
> for an application to work during winter, and stop working when the
> daylight saving time begins.

I agree with everything Heikki says. As the original author of the
timezone files I guess that I am to blame for not having included PKST
in the first place. However I have the excuse that it was like that
already back when the timezone information was still hardcoded, we had
"pkt" but not "pkst":


http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?rev=1.168;content-type=text%2Fx-cvsweb-markup

Good we have found that inconsistency now, so let's add PKST.

I also agree with not adding more than necessary to the default config
set. Given that so few people complain about it we seem to have a good
working default set already.


Joachim


pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: SHARE locks vs. DELETE in SERIALIZABLE mode (Was: Partitioning/inherited tables vs FKs)
Next
From: Tom Lane
Date:
Subject: Re: Patch for PKST timezone