Re: [HACKERS] PL/Python: Add cursor and execute methods to planobject - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [HACKERS] PL/Python: Add cursor and execute methods to planobject
Date
Msg-id ff9f02bc-ad89-accd-5f31-a9a6e3c7e315@2ndQuadrant.com
Whole thread Raw
In response to Re: [HACKERS] PL/Python: Add cursor and execute methods to plan object  (David Steele <david@pgmasters.net>)
Responses Re: [HACKERS] PL/Python: Add cursor and execute methods to planobject  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers

On 03/16/2017 05:32 PM, David Steele wrote:
> On 2/25/17 1:27 PM, Peter Eisentraut wrote:
>> Something that has been bothering me in PL/Python for a long time is the
>> non-object-oriented way in which plans are prepared and executed:
>>
>>     plan = plpy.prepare(...)
>>     res = plpy.execute(plan, ...)
>>
>> where plpy.execute() takes either a plan or a query string.
>>
>> I think a better style would be
>>
>>     plan = plpy.prepare(...)
>>     res = plan.execute(...)
>>
>> so that the "plan" is more like a statement handle that one finds in
>> other APIs.
>>
>> This ended up being very easy to implement, so I'm proposing to allow
>> this new syntax as an alternative.
>>
>> I came across this again as I was developing the background sessions API
>> for PL/Python.  So I'm also wondering here which style people prefer so
>> I can implement it there.
> This patch applies cleanly at cccbdde.
>
> Any Python folks out there who would like to take a crack at reviewing this?
>
>


I'm not particularly a Python folk, but I've done enough over the years
with PLs, including PLPython, that I think I can review this :-)

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: [HACKERS] Re: proposal - psql: possibility to specify sort for describecommands, when size is printed
Next
From: Dmitry Dolgov
Date:
Subject: Re: [HACKERS] [PATCH] few fts functions for jsonb