Re: SLRU statistics - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: SLRU statistics
Date
Msg-id fe3332c8-485a-540b-ca34-b024d452a7ae@oss.nttdata.com
Whole thread Raw
In response to Re: SLRU statistics  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: SLRU statistics
Re: SLRU statistics
List pgsql-hackers

On 2020/05/13 23:26, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> On 2020/05/13 17:21, Tomas Vondra wrote:
>>> On Wed, May 13, 2020 at 04:10:30PM +0900, Fujii Masao wrote:
>>>> Also I found another minor issue; SLRUStats has not been initialized to 0
>>>> and which could update the counters unexpectedly. Attached patch fixes
>>>> this issue.
> 
>> Pushed both. Thanks!
> 
> Why is that necessary?  A static variable is defined by C to start off
> as zeroes.

Because SLRUStats is not a static variable. No?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Inefficiency in SLRU stats collection
Next
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: Strange decreasing value of pg_last_wal_receive_lsn()