Re: SLRU statistics - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SLRU statistics
Date
Msg-id 32135.1589379999@sss.pgh.pa.us
Whole thread Raw
In response to Re: SLRU statistics  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: SLRU statistics  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Re: SLRU statistics  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2020/05/13 17:21, Tomas Vondra wrote:
>> On Wed, May 13, 2020 at 04:10:30PM +0900, Fujii Masao wrote:
>>> Also I found another minor issue; SLRUStats has not been initialized to 0
>>> and which could update the counters unexpectedly. Attached patch fixes
>>> this issue.

> Pushed both. Thanks!

Why is that necessary?  A static variable is defined by C to start off
as zeroes.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: refactoring basebackup.c
Next
From: Fujii Masao
Date:
Subject: Re: Add explanations which are influenced by track_io_timing