Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_stat_statements and "IN" conditions - Mailing list pgsql-hackers

From David Steele
Subject Re: pg_stat_statements and "IN" conditions
Date
Msg-id ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net
Whole thread Raw
In response to Re: pg_stat_statements and "IN" conditions  (Zhihong Yu <zyu@yugabyte.com>)
Responses Re: pg_stat_statements and "IN" conditions  (Dmitry Dolgov <9erthalion6@gmail.com>)
List pgsql-hackers
Tree view 
On 1/5/21 10:51 AM, Zhihong Yu wrote:
> 
> +   int         lastExprLenght = 0;
> 
> Did you mean to name the variable lastExprLenghth ?
> 
> w.r.t. extracting to helper method, the second and third 
> if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> It is up to you whether to create the helper method.
> I am fine with the current formation.

Dmitry, thoughts on this review?

Regards,
-- 
-David
david@pgmasters.net

pgsql-hackers by date:

Previous
From: Ibrar Ahmed
Date:
Subject: Re: should INSERT SELECT use a BulkInsertState?
Next
From: Surafel Temesgen
Date:
Subject: Re: Calendar support in localization