Postgres Pro
Downloads
Home   >   mailing lists

Re: Add a test for "cannot truncate foreign table" - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Add a test for "cannot truncate foreign table"
Date
Msg-id ebfc16eb-10b5-30b3-152f-f58bedbf5a94@oss.nttdata.com
Whole thread Raw
In response to Add a test for "cannot truncate foreign table"  (Yugo NAGATA <nagata@sraoss.co.jp>)
Responses Re: Add a test for "cannot truncate foreign table"
List pgsql-hackers
Tree view 

On 2022/06/30 10:48, Yugo NAGATA wrote:
> Hello,
> 
> During checking regression tests of TRUNCATE on foreign
> tables for other patch [1], I found that there is no test
> for foreign tables that don't support TRUNCATE.
> 
> When a foreign table has handler but doesn't support TRUNCATE,
> an error "cannot truncate foreign table xxx" occurs. So, what
> about adding a test this message output? We can add this test
> for file_fdw because it is one of the such foreign data wrappers.
> 
> I attached a patch.

Thanks for the patch! It looks good to me.
I changed the status of this patch to ready-for-committer,
and will commit it barring any objeciton.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Use outerPlanState macro instead of referring to leffttree
Next
From: Tom Lane
Date:
Subject: Re: Add a test for "cannot truncate foreign table"