Re: Add a test for "cannot truncate foreign table" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add a test for "cannot truncate foreign table"
Date
Msg-id 2983289.1657207980@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add a test for "cannot truncate foreign table"  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Add a test for "cannot truncate foreign table"
List pgsql-hackers
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2022/06/30 10:48, Yugo NAGATA wrote:
>> When a foreign table has handler but doesn't support TRUNCATE,
>> an error "cannot truncate foreign table xxx" occurs. So, what
>> about adding a test this message output? We can add this test
>> for file_fdw because it is one of the such foreign data wrappers.

> Thanks for the patch! It looks good to me.
> I changed the status of this patch to ready-for-committer,
> and will commit it barring any objeciton.

This seems like a fairly pointless expenditure of test cycles
to me.  Perhaps more importantly, what will you do when
somebody adds truncate support to that FDW?  I don't think
there's an inherent reason for it to be read-only.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Add a test for "cannot truncate foreign table"
Next
From: Tom Lane
Date:
Subject: Re: archive modules