Re: GROUP BY DISTINCT - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: GROUP BY DISTINCT
Date
Msg-id ea0cc900-174a-0f51-539f-5f51af8b4097@postgresfriends.org
Whole thread Raw
In response to Re: GROUP BY DISTINCT  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List pgsql-hackers
On 3/19/21 12:52 AM, Tomas Vondra wrote:
> 
> On 3/19/21 12:26 AM, Tom Lane wrote:
>> I wrote:
>>> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7.
>>> I'll work on figuring that out.
>>
>> Actually, the problem is pretty obvious after comparing this use
>> of foreach_delete_current() to every other one.  I'm not sure why
>> the compiler warnings are phrased just as they are, but the fix
>> I just pushed does make 4.5 happy.
>>
> 
> Thanks! Yeah, that looks obvious. Funny the older compilers noticed
> this, not the new fancy ones.

+1

I'm glad the buildfarm is so diverse.
-- 
Vik Fearing



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore
Next
From: Tom Lane
Date:
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore