Postgres Pro
Downloads
Home   >   mailing lists

Re: GROUP BY DISTINCT - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: GROUP BY DISTINCT
Date
Msg-id a0160421-654c-885e-1e90-5c21e9e1ab72@enterprisedb.com
Whole thread Raw
In response to Re: GROUP BY DISTINCT  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: GROUP BY DISTINCT  (Vik Fearing <vik@postgresfriends.org>)
List pgsql-hackers
Tree view 
On 3/19/21 12:26 AM, Tom Lane wrote:
> I wrote:
>> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7.
>> I'll work on figuring that out.
> 
> Actually, the problem is pretty obvious after comparing this use
> of foreach_delete_current() to every other one.  I'm not sure why
> the compiler warnings are phrased just as they are, but the fix
> I just pushed does make 4.5 happy.
> 

Thanks! Yeah, that looks obvious. Funny the older compilers noticed
this, not the new fancy ones.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore
Next
From: Peter Geoghegan
Date:
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore