Thanks for the review.
On 2019/03/07 21:35, Etsuro Fujita wrote:
> The patch looks good to me, but one thing I'm wondering is: as suggested
> by David, it would be better to rephrase this mention in the UPDATE
> reference page, in a single commit:
>
> "Currently, rows cannot be moved from a partition that is a foreign table
> to some other partition, but they can be moved into a foreign table if the
> foreign data wrapper supports it."
>
> I don't think it needs to be completely rephrased; it's enough for me to
> rewrite it to something like this:
>
> "Currently, rows cannot be moved from a foreign-table partition to some
> other partition, but they can be moved into a foreign-table partition if
> the foreign data wrapper supports tuple routing."
>
> And to make maintenance work easy, I think it might be better to just put
> this on the limitations section of 5.10. Table Partitioning. What do you
> think about that?
I agree, so updated the patch this way.
David, can you confirm if the rewritten text reads unambiguous or perhaps
suggest a better wording?
Thanks,
Amit