Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id e51f66da0809010637r182327acx7c637c4cd9d3e4e5@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Cleanup of GUC units code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Cleanup of GUC units code  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On 9/1/08, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Marko Kreen <markokr@gmail.com> writes:
>  > - In attempt to preserve maximum range of values for INT64_IS_BUSTED
>  >   systems, the code is written rather non-obvious way.
>
> I do not personally object a bit to making the units comparisons
>  case-insensitive (I think it's mainly Peter who wants to be strict
>  about it).  I don't think there are any other good ideas in this
>  patch, however, and exposing ourselves to intermediate overflows in
>  the name of simplicity is definitely not one.

For all practical purposes, the overflow is insignificant when int64
works.  I'll look if I can avoid it on INT64_IS_BUSTED case.

In the meantime, here is simple patch for case-insensivity.

--
marko

Attachment

pgsql-hackers by date:

Previous
From: "Marko Kreen"
Date:
Subject: Re: [PATCH] Make gram.y use palloc/pfree for memory management
Next
From: Stephen Frost
Date:
Subject: Re: Extending grant insert on tables to sequences