Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id 2879.1220237795@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Cleanup of GUC units code  (Marko Kreen <markokr@gmail.com>)
Responses Re: [PATCH] Cleanup of GUC units code  ("Marko Kreen" <markokr@gmail.com>)
List pgsql-hackers
Tree view 
Marko Kreen <markokr@gmail.com> writes:
> - In attempt to preserve maximum range of values for INT64_IS_BUSTED
>   systems, the code is written rather non-obvious way.

I do not personally object a bit to making the units comparisons
case-insensitive (I think it's mainly Peter who wants to be strict
about it).  I don't think there are any other good ideas in this
patch, however, and exposing ourselves to intermediate overflows in
the name of simplicity is definitely not one.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Make gram.y use palloc/pfree for memory management
Next
From: Tom Lane
Date:
Subject: WIP: extend parser to show error locations in more cases