Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic. - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.
Date
Msg-id e2bf48bd-3525-d4c5-34d7-5748683207bb@2ndQuadrant.com
Whole thread Raw
In response to pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Tree view 
On 4/3/20 3:32 PM, Robert Haas wrote:
> pg_validatebackup: Adjust TAP tests to placate perlcritic.
>
> It seems that we have a policy that every Perl subroutine should
> end with an explicit "return", so add explicit "return"
> statements to all the new subroutines added by my prior
> commit 0d8c9c1210c44b36ec2efcb223a1dfbe897a3661.



It was discussed here 
https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: pg_validatebackup: Also use perl2host in TAP tests.
Next
From: Robert Haas
Date:
Subject: pgsql: pg_validatebackup: Adjust TAP tests to undo permissions change.