Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.
Date
Msg-id CA+TgmobjGn7vJ62_TgSgR6xmBK5ofRbTyxy8Yx_4_D-f5SLgTg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-committers
On Fri, Apr 3, 2020 at 5:40 PM Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> On 4/3/20 3:32 PM, Robert Haas wrote:
> > pg_validatebackup: Adjust TAP tests to placate perlcritic.
> >
> > It seems that we have a policy that every Perl subroutine should
> > end with an explicit "return", so add explicit "return"
> > statements to all the new subroutines added by my prior
> > commit 0d8c9c1210c44b36ec2efcb223a1dfbe897a3661.
>
> It was discussed here
> https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com

Yeah, I understand that I probably should have been aware of this. I
just wasn't.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: pg_validatebackup: Adjust TAP tests to undo permissions change.
Next
From: Robert Haas
Date:
Subject: pgsql: pg_validatebackup: Fix 'make clean' to remove tmp_check.