On 2025-10-06 Mo 6:44 AM, Nazir Bilal Yavuz wrote:
> Hi,
>
> On Mon, 6 Oct 2025 at 11:54, Peter Eisentraut <peter@eisentraut.org> wrote:
>> On 06.10.25 10:29, Nazir Bilal Yavuz wrote:
>>> I can work on this but I want to clarify it first. Which one do you prefer:
>>>
>>> 1- We won't have any command to do syntax checks (including tab and
>>> nbsp), these checks will automatically run when we generate docs.
>>>
>>> 2- We will have a 'check' target but it will only do tab and nbsp
>>> checks; xmllint will run only when generating the docs.
>> I don't know, people have a lot of individual workflows, and they are
>> not reading this thread. I still don't know what we are actually trying
>> to fix here, I just noticed that what was committed is flawed.
> The problem was meson build doesn't have tab and nbsp checks [1]. We
> were trying to enable these checks on meson build by moving these
> checks to the perl script so that we can run this script on both build
> systems.
>
>> I would prefer that b2922562726 be reverted, and then someone start a
>> new thread with a descriptive change proposal.
> Sounds good to me. I can create a new thread if it gets reverted.
>
> [1] https://www.postgresql.org/message-id/7020df24-1d5f-41e5-8948-2e8d5da57935%40dunslane.net
OK, reverted.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
