Re: [HACKERS] Typo in insert.sgml - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Typo in insert.sgml
Date
Msg-id e133c86c-55ae-0ad6-b25c-1a73cbf888b7@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Typo in insert.sgml  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-hackers
On 6/20/17 15:03, David G. Johnston wrote:
> On Tuesday, June 20, 2017, Robert Haas <robertmhaas@gmail.com
> <mailto:robertmhaas@gmail.com>> wrote:
> 
>     On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
>     <peter.eisentraut@2ndquadrant.com <javascript:;>> wrote:
>     > On 6/18/17 03:16, Julien Rouhaud wrote:
>     >> Patch attached.
>     >
>     > This was not a typo, this was intentional.
> 
>     To me, Julien's change seems to make it easier to understand, but
>     maybe I'm misunderstanding what it's trying to say in the first place.
> 
> 
> Maybe
> 
> [...] that are not identity columns in <literal>tbl2</literal>. Values
> for identity columns will come from the sequence generators for
> <literal>tbl2</literal>.
> 
> Otherwise I'd drop the word "continue" altogether and just say "but will
> use the sequence counters for".

I have committed something along those lines.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Michael Malis
Date:
Subject: Re: [HACKERS] Re: Poor cost estimate with interaction between tablecorrelation and partial indexes
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] pgbench: faster version of tpcb-like transaction