Re: [HACKERS] Typo in insert.sgml - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: [HACKERS] Typo in insert.sgml
Date
Msg-id CAKFQuwatuFwvr_61Afdm0S2Kb3VWzH6xqJbxdAacu3t-LS6yig@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Typo in insert.sgml  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Typo in insert.sgml  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Tuesday, June 20, 2017, Robert Haas <robertmhaas@gmail.com> wrote:
On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 6/18/17 03:16, Julien Rouhaud wrote:
>> Patch attached.
>
> This was not a typo, this was intentional.

To me, Julien's change seems to make it easier to understand, but
maybe I'm misunderstanding what it's trying to say in the first place.


Maybe

[...] that are not identity columns in <literal>tbl2</literal>. Values for identity columns will come from the sequence generators for <literal>tbl2</literal>.

Otherwise I'd drop the word "continue" altogether and just say "but will use the sequence counters for".

David J.

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Optional message to user when terminating/cancellingbackend
Next
From: Álvaro Hernández Tortosa
Date:
Subject: Re: [HACKERS] Channel binding support for SCRAM-SHA-256