Re: Improvements in psql hooks for variables - Mailing list pgsql-hackers

From Daniel Verite
Subject Re: Improvements in psql hooks for variables
Date
Msg-id de7ebdcd-6f4b-47b9-9612-71dffb8355a6@mm
Whole thread Raw
In response to Re: Improvements in psql hooks for variables  ("Daniel Verite" <daniel@manitou-mail.org>)
Responses Re: Improvements in psql hooks for variables
Re: Improvements in psql hooks for variables
List pgsql-hackers
   I wrote:

> So I went through the psql commands which don't fail on parse errors
> for booleans
> [...]

Here's a v5 patch implementing the suggestions mentioned upthread:
all meta-commands calling ParseVariableBool() now fail
when the boolean argument can't be parsed successfully.

Also includes a minor change to SetVariableAssignHook() that now
returns the result of the hook it calls after installing it.
It doesn't make any difference in psql behavior since callers
of SetVariableAssignHook() ignore its return value, but it's
more consistent with SetVariable().

Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Creating a DSA area to provide work space for parallel execution
Next
From: Craig Ringer
Date:
Subject: [bugfix] commit timestamps ERROR on lookup of FrozenTransactionId