Re: Improvements in psql hooks for variables - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: Improvements in psql hooks for variables
Date
Msg-id CAJrrPGdQ0+WW3W87aYS2iHZgD2F4m8bPECzdED0fyLF74FHJWw@mail.gmail.com
Whole thread Raw
In response to Re: Improvements in psql hooks for variables  ("Daniel Verite" <daniel@manitou-mail.org>)
List pgsql-hackers


On Wed, Nov 23, 2016 at 11:17 PM, Daniel Verite <daniel@manitou-mail.org> wrote:
   I wrote:

> So I went through the psql commands which don't fail on parse errors
> for booleans
> [...]

Here's a v5 patch implementing the suggestions mentioned upthread:
all meta-commands calling ParseVariableBool() now fail
when the boolean argument can't be parsed successfully.

Also includes a minor change to SetVariableAssignHook() that now
returns the result of the hook it calls after installing it.
It doesn't make any difference in psql behavior since callers
of SetVariableAssignHook() ignore its return value, but it's
more consistent with SetVariable().

Moved to next CF with "needs review" status.

Regards,
Hari Babu
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: patch proposal
Next
From: Haribabu Kommi
Date:
Subject: Re: Supporting huge pages on Windows