Re: [PATCH] Little refactoring of portalcmds.c - Mailing list pgsql-hackers

From Quan Zongliang
Subject Re: [PATCH] Little refactoring of portalcmds.c
Date
Msg-id dbe56aa6-76df-4824-a621-ffb890dbbfde@yeah.net
Whole thread Raw
In response to [PATCH] Little refactoring of portalcmds.c  (Aleksander Alekseev <aleksander@tigerdata.com>)
Responses Re: [PATCH] Little refactoring of portalcmds.c
List pgsql-hackers

On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
> 
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
> 

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang




pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Next
From: "Joel Jacobson"
Date:
Subject: Re: Optimize LISTEN/NOTIFY