Re: GUC names in messages - Mailing list pgsql-hackers

From Laurenz Albe
Subject Re: GUC names in messages
Date
Msg-id db3e4290ced77111c17e7a2adfb1d660734f5f78.camel@cybertec.at
Whole thread Raw
In response to Re: GUC names in messages  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: GUC names in messages
List pgsql-hackers
On Mon, 2023-11-27 at 13:41 +1100, Peter Smith wrote:
> TBH, I suspect something fishy about these mixed-case GUCs.
>
> In the documentation and in the guc_tables.c they are all described in
> MixedCase (e.g. "DateStyle" instead of "datestyle"), so I felt the
> messages should use the same case the documentation, which is why I
> changed all the ones you are referring to.

I agree with that decision; we should use mixed case for these parameters.

Otherwise we might get complaints that the following query does not return
any results:

  SELECT * FROM pg_settings WHERE name = 'timezone';

Yours,
Laurenz Albe



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Incorrect comment in tableam.h regarding GetHeapamTableAmRoutine()
Next
From: Tom Lane
Date:
Subject: Re: GUC names in messages