Re: GUC names in messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GUC names in messages
Date
Msg-id 3772065.1701066944@sss.pgh.pa.us
Whole thread Raw
In response to Re: GUC names in messages  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: GUC names in messages
List pgsql-hackers
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Mon, 2023-11-27 at 13:41 +1100, Peter Smith wrote:
>> In the documentation and in the guc_tables.c they are all described in
>> MixedCase (e.g. "DateStyle" instead of "datestyle"), so I felt the
>> messages should use the same case the documentation, which is why I
>> changed all the ones you are referring to.

> I agree with that decision; we should use mixed case for these parameters.
> Otherwise we might get complaints that the following query does not return
> any results:
>   SELECT * FROM pg_settings WHERE name = 'timezone';

Yeah.  Like Michael upthread, I've wondered occasionally about changing
these names to all-lower-case.  It'd surely be nicer if we'd done it
like that to begin with.  But I can't convince myself that the ensuing
user pain would be justified.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: GUC names in messages
Next
From: Amit Kapila
Date:
Subject: Re: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15