Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Date
Msg-id d78dcc0e-9879-3b8e-b901-aa519b91ee98@2ndQuadrant.com
Whole thread Raw
In response to Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 10/12/2018 12:20 PM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> I'm asking again, what exactly do we test by having these types in the
>> dump? They're bog standard types, there's nothing new for pg_dump to
>> test with them. No weird typmod rules, no weird parse-time type mapping,
>> nothing?
> That's a pretty fair point.  The types' I/O functions will be exercised
> well enough by the regression tests themselves, and it's hard to see what
> more test coverage is gained by including them in pg_dump/pg_upgrade
> testing.  Maybe we should just drop those tables and be done with it.
>

If you're happy with that then go for it. It will be less work for me ;-)

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: partition tree inspection functions
Next
From: Alvaro Herrera
Date:
Subject: Re: partition tree inspection functions