Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Date
Msg-id 10740.1539361242@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I'm asking again, what exactly do we test by having these types in the
> dump? They're bog standard types, there's nothing new for pg_dump to
> test with them. No weird typmod rules, no weird parse-time type mapping,
> nothing?

That's a pretty fair point.  The types' I/O functions will be exercised
well enough by the regression tests themselves, and it's hard to see what
more test coverage is gained by including them in pg_dump/pg_upgrade
testing.  Maybe we should just drop those tables and be done with it.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re: Continue work on changes to recovery.conf API
Next
From: Alvaro Herrera
Date:
Subject: constraints names on partitions