Neil Conway <neilc@samurai.com> writes: > Attached is a revised version of this patch.
This still seems to fundamentally misunderstand the difference between an index and a constraint. IMHO it should not be examining pg_index (or specifically, the index Relations) at all.
But as you had mentioned earlier, if we look at index entries as part of the implementation of "unique" or "primary key" pg_constraint entries, then examining pg_index is required, right?
Anyways, this patch and the functionality introduced herein will be useful in the "CREATE .. INCLUDING INDEXES" case too.
