Re: doc fixes: vacuum_cleanup_index_scale_factor - Mailing list pgsql-hackers

From Liudmila Mantrova
Subject Re: doc fixes: vacuum_cleanup_index_scale_factor
Date
Msg-id d3966a0e-232d-2fc2-c3de-3c20fbaf0a9d@postgrespro.ru
Whole thread Raw
In response to Re: doc fixes: vacuum_cleanup_index_scale_factor  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: doc fixes: vacuum_cleanup_index_scale_factor
List pgsql-hackers
On 05/08/2018 02:05 PM, Justin Pryzby wrote:
> 3rd iteration ; thanks for bearing with me.
>
> On Tue, May 08, 2018 at 12:35:00PM +0300, Alexander Korotkov wrote:
>> Hi, Justin!
>>
>> Thank you for revising documentation patch.
>>
>> On Mon, May 7, 2018 at 7:55 PM, Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> +        In order to detect stale index statistics, the number of total heap
> +        tuples during previous statistics collection is stored in the index
> +        meta-page.
>
> Consider removing: "during previous statistics collection"
> Or: "during THE previous statistics collection"
>
> + Once the number of inserted tuples since previous
>
> since THE previous
>
> +        statistics collection is more than
> +        <varname>vacuum_cleanup_index_scale_factor</varname> fraction of
>
> Since the multiplier can be greater than 1, should we say "multiple" instead of
> fraction?
>
> +        during <command>VACUUM</command> cycle.  Thus, skipping of the B-tree
> +        index scan during cleanup stage is only possible when second and
> +        subsequent <command>VACUUM</command> cycles detecting no dead tuples.
>
> Change "detecting" to "detect".  Or maybe just "find"
>
> Justin
>
Hi Justin,

Thank you for helping with the docs. Attached is another doc patch that 
should address most of the issues you've brought up.
I've also reshuffled the text a bit to make it more like an option 
description. Hope you'll find it useful.

-- 
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Needless additional partition check in INSERT?
Next
From: Ashutosh Bapat
Date:
Subject: Test for trigger condition accessing system attributes