Re: Allow some recovery parameters to be changed with reload - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Allow some recovery parameters to be changed with reload
Date
Msg-id d33c954e-a505-66bc-996e-5a92caaffbfe@oss.nttdata.com
Whole thread Raw
In response to Re: Allow some recovery parameters to be changed with reload  (Sergei Kornilov <sk@zsrv.org>)
Responses Re: Allow some recovery parameters to be changed with reload  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers

On 2020/11/12 4:38, Sergei Kornilov wrote:
> Hello
> 
>> Anyway, for now I think that your first patch would be enough, i.e.,
>> just change the context of restore_command to PGC_SIGHUP.
> 
> Glad to hear. Attached a rebased version of the original proposal.

Thanks for rebasing the patch!

     This parameter is required for archive recovery,

I found the above description in config.sgml. I was just wondering
if it should be updated so that the actual specification is described or not.
The actual spec is that restore_command is required to start archive
recovery, but optional (i.e., the parameter can be reset to an empty)
after archive recovery has started. But this updated version of
description would be rather confusing to users. So I'm now thinking
not to update that.

Does anyone object to the patch? If no, I'm thinking to commit the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Improper use about DatumGetInt32
Next
From: Bharath Rupireddy
Date:
Subject: Re: Multi Inserts in CREATE TABLE AS - revived patch