Re: START_REPLICATION SLOT causing a crash in an assert build - Mailing list pgsql-hackers

From Jonathan S. Katz
Subject Re: START_REPLICATION SLOT causing a crash in an assert build
Date
Msg-id d1bd5065-ca79-d833-2d7d-0b0404589711@postgresql.org
Whole thread Raw
In response to Re: START_REPLICATION SLOT causing a crash in an assert build  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: START_REPLICATION SLOT causing a crash in an assert build  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 9/27/22 1:52 AM, Kyotaro Horiguchi wrote:
> Thanks!
> 
> At Mon, 26 Sep 2022 19:53:02 -0700, Andres Freund <andres@anarazel.de> wrote in
>> I wonder if the correct fix here wouldn't be to move the slotname out of
>> PgStat_StatReplSlotEntry?
> 
> Ugh. Right. I thought its outer struct as purely the part for the
> common header. But we can freely place anything after the header
> part. I moved it to the outer struct. I didn't clear that part in
> pgstat_create_relation() because it is filled in immediately.
> 
> The attached is that.

This is still listed as an open item[1] for v15. Does this fix proposed 
address the issue?

Thanks,

Jonathan

[1] https://wiki.postgresql.org/wiki/PostgreSQL_15_Open_Items


Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [BUG] parenting a PK constraint to a self-FK one (Was: Self FK oddity when attaching a partition)
Next
From: Andres Freund
Date:
Subject: Re: [RFC] building postgres with meson - v13