Re: Move block_range_read_stream_cb batchmode comment - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Move block_range_read_stream_cb batchmode comment
Date
Msg-id chtu5m6rbjl4h73l2zyhr2o7ex5jg5ymy3srx7bnmmhpubc6bz@u4nfqvole4px
Whole thread Raw
In response to Move block_range_read_stream_cb batchmode comment  (Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>)
Responses Re: Move block_range_read_stream_cb batchmode comment
List pgsql-hackers
Hi,

On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
> Currently, each usage of block_range_read_stream_cb is accompanied by
> the same comment about the safety of using batchmode (there are 7
> identical comments)

-1 - I think it's better to have the analysis at the point of using the flag
and callback, as otherwise it's too easy to change the callsites to a
different callback, without removing the flag.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: COPY TO: provide hint when WHERE clause is used
Next
From: Tom Lane
Date:
Subject: Re: PG 18 relnotes and RC1