Re: Move block_range_read_stream_cb batchmode comment - Mailing list pgsql-hackers

From Arseniy Mukhin
Subject Re: Move block_range_read_stream_cb batchmode comment
Date
Msg-id CAE7r3MJgWAeQwSD2VUMM+0qjBgtAA2M=m+sMN=bEffecEXctXg@mail.gmail.com
Whole thread Raw
In response to Re: Move block_range_read_stream_cb batchmode comment  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Sat, Aug 30, 2025 at 9:14 PM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
> > Currently, each usage of block_range_read_stream_cb is accompanied by
> > the same comment about the safety of using batchmode (there are 7
> > identical comments)
>
> -1 - I think it's better to have the analysis at the point of using the flag
> and callback, as otherwise it's too easy to change the callsites to a
> different callback, without removing the flag.
>

Got the idea, thank you for the explanation.

Best regards,
Arseniy Mukhin



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PG 18 relnotes and RC1
Next
From: Nathan Bossart
Date:
Subject: Re: PG 18 relnotes and RC1