Re: Indentation in a patch - Mailing list pgsql-general

From Peter Eisentraut
Subject Re: Indentation in a patch
Date
Msg-id cced0f25-8eb3-4af4-9c5f-6ea2a32cb351@eisentraut.org
Whole thread Raw
In response to Re: Indentation in a patch  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-general
On 25.11.25 19:58, Daniel Gustafsson wrote:
>> On 25 Nov 2025, at 19:14, Bernice Southey <bernice.southey@gmail.com> wrote:
> 
>> .. for my first ever patch attempt.
> 
> Awesome, we love to see new contributors!
> 
>> I'm tempted to submit my patch without indenting the
>> if-block, and an explanation.
> 
> That's perfectly fine, an incorrectly indentend diff is fine to submit if it
> makes it more readable (especially when coupled with a note explaining why).

Alternatively or additionally, git diff -w/--ignore-all-space can be 
useful in situations like this.




pgsql-general by date:

Previous
From: immerrr again
Date:
Subject: Re: DROP ROLE blocked by pg_init_privs
Next
From: atma ram
Date:
Subject: Question on PostgreSQL Table Partitioning – Performance of Queries That Do Not Use the Partition Key