Re: Indentation in a patch - Mailing list pgsql-general

From Daniel Gustafsson
Subject Re: Indentation in a patch
Date
Msg-id 2595B96D-0A6E-472D-964A-8E87EC3B1C6B@yesql.se
Whole thread Raw
In response to Indentation in a patch  (Bernice Southey <bernice.southey@gmail.com>)
Responses Re: Indentation in a patch
List pgsql-general
> On 25 Nov 2025, at 19:14, Bernice Southey <bernice.southey@gmail.com> wrote:

> .. for my first ever patch attempt.

Awesome, we love to see new contributors!

> I'm tempted to submit my patch without indenting the
> if-block, and an explanation.

That's perfectly fine, an incorrectly indentend diff is fine to submit if it
makes it more readable (especially when coupled with a note explaining why).

> While I'm asking, I added a regression test and ran make check-world
> with the TAP tests. Anything else I should do before sending it to
> hackers?

Sounds like you've completed all the required steps.

--
Daniel Gustafsson




pgsql-general by date:

Previous
From: Bernice Southey
Date:
Subject: Indentation in a patch
Next
From: Rich Shepard
Date:
Subject: Re: Selecting all variations of job title in a list