Hi,
On 8/23/22 4:25 AM, Michael Paquier wrote:
> On Mon, Aug 22, 2022 at 08:10:10AM -0700, Jacob Champion wrote:
>> otherwise I'll sit tight.
> So am I. I have done an extra round of checks around the
> serialization/deserialization logic where I put some elog()'s to look
> at the output passed down with some workers and a couple of auth
> methods, and after an indentation and some comment polishing I finish
> with the attached.
>
> There was one thing that annoyed me with the patch, though, as of the
> lack of initialization of MyClientConnectionInfo at backend startup,
> as we may finish by not calling set_authn() to fill in some of its
> data, so I have placed an extra memset(0) in InitProcessGlobals()
Fair point.
> (note that Port does a calloc() much earlier than that, but I think
> that we don't really want to do more in such code paths, especially
> for the parallelized client information).
>
> I have written a commit message, while on it. Does that look fine to
> you?
Thanks!
That sounds all good to me, except a typo for the author in the commit
message: s/Jocob/Jacob/
Regards,
--
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com
