Hi David,
On 03/01/2018 08:04 AM, David Rowley wrote:
> I've also split the patch out a bit more into logical parts in the
> hope it makes things easier to review.
>
A small typo in 0001:
+ * leftmost_ons_pos[x] gives the bit number (0-7) of the leftmost one
bit in a
..."_one_"...
0004 fails "make check-world" due to
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 670; 1259 49954 TABLE
boolp_f jpedersen
pg_restore: [archiver (db)] could not execute query: ERROR: syntax
error at or near "false"
LINE 24: ..." ATTACH PARTITION "public"."boolp_f" FOR VALUES IN (false);
Do you require https://commitfest.postgresql.org/17/1410/ as well ?
I'll look more at 0002-0005 over the coming days.
Thanks for working on this !
Best regards,
Jesper
