Re: astreamer fixes - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: astreamer fixes
Date
Msg-id c2fb2a5b-d7fc-4d25-b6f7-db6ab51c5e1b@dunslane.net
Whole thread Raw
In response to Re: astreamer fixes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On 2026-03-28 Sa 3:46 PM, Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
On 2026-03-28 Sa 1:48 PM, Tom Lane wrote:
but I don't like the other bit

+		/* If we've hit the end of the compressed stream, stop. */
+		if (res == Z_STREAM_END)
+			break;

Paying attention to the amount of data consumed seems just as
good and takes less code.
So IIUC, you agree with the patch except for this last piece, on which I 
agree with your reasoning.
Right, I would leave out the above-quoted hunk but the rest of it
looks good.
			


Thanks. pushed.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Exit walsender before confirming remote flush in logical replication
Next
From: Tomas Vondra
Date:
Subject: Re: pg_waldump: support decoding of WAL inside tarfile