Re: Exit walsender before confirming remote flush in logical replication - Mailing list pgsql-hackers

Hi, Fujii!

On Wed, Mar 25, 2026 at 2:39 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> In my tests, the shutdown in step #6 got stuck.
>
> Any thoughts on whether this indicates a problem in the patch or
> something off in my setup?

I tried your test case, but I didn't stuck for me while using v5 patch
from Andrey [1].

One possible idea why hand may happen for is is that
WalSndWaitForWal() has missing WalSndCheckShutdownTimeout() call.  See
the patch attached.  Could I ask you, to retry with this patch applied
on top of v5 patch by Andrey [1].  And also, if possible, turn your
test into a perl tap test inside 038_walsnd_shutdown_timeout.pl.

Thank you.

Links
1. https://www.postgresql.org/message-id/aed6b990-e7d8-40d1-96a4-64ccbfbda876%40postgrespro.ru

------
Regards,
Alexander Korotkov
Supabase